Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate ephemeral-storage requests and limits configuration using deploy labels #1935

Open
jvitor83 opened this issue Sep 27, 2024 · 0 comments · May be fixed by #1936
Open

Generate ephemeral-storage requests and limits configuration using deploy labels #1935

jvitor83 opened this issue Sep 27, 2024 · 0 comments · May be fixed by #1936
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jvitor83
Copy link
Contributor

jvitor83 commented Sep 27, 2024 •
edited
Loading

What would you like to be added?

Allow to use labels in the deploy section to convert to kubernetes resources requests and limits for ephemeral-storage.

Example:

services:
  app:
    image: node:18-alpine
    ports:
      - 3000:3000
    deploy:
      labels:
        requests.ephemeral-storage: 1Gi
        limits.ephemeral-storage: 1Gi

Generates:

apiVersion: apps/v1
kind: Deployment
...
spec:
    ...
    spec:
      containers:
        - image: node:18-alpine
          name: app
          ports:
            - containerPort: 3000
              protocol: TCP
          resources:
            limits:
              ephemeral-storage: 1Gi
            requests:
              ephemeral-storage: 1Gi

Why is this needed?

By using the generated yaml files, if those ephemeral-storage resources configuration didn't exists and if the cluster where the deploy will happen are on low ephemeral storage, this gives an error.
By have the possibility to put those config, we can properly set how much reserve should have.
@jvitor83 jvitor83 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2024
@jvitor83 jvitor83 linked a pull request Sep 27, 2024 that will close this issue
Open
@jvitor83 jvitor83 changed the title Include ephemeral-storage requests and limits configuration using deploy labels Generate ephemeral-storage requests and limits configuration using deploy labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(deploy): support ephemeral storage requests limits labels jvitor83/kompose
1 participant
@jvitor83