Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for network_mode: service:* #1846

Closed
jan-hudec opened this issue Mar 22, 2024 · 4 comments
Closed

Support for network_mode: service:* #1846

jan-hudec opened this issue Mar 22, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jan-hudec
Copy link

What would you like to be added?

When a service has network_mode of the form service:anotherservice, it should be added as a second container into the deployment of anotherservice instead of getting its own deployment. Because this specification means the services will see each other on localhost, which roughly corresponds to being in the same pod in kubernetes.

Why is this needed?

I tried to convert https://github.com/dehydr8/elevation-of-privilege/blob/master/docker-compose.yml to Kubernetes, but the resulting manifest can't be used as is, because the two containers are set up so the client one, working as reverse proxy for server, references the server at three fixed addresses ws://localhost:8000, http://locahost:8001 and http://localhost:8002 and if they are started in separate pods, they can't.

@jan-hudec jan-hudec added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 22, 2024
@devinrhode2
Copy link

I think This just saved me the trouble of trying to use kompose, and instead what ill need to do, until this issue is resolved, is try to directly author a pod which runs two containers

@devinrhode2
Copy link

Actually looks like this issue can be closed based on this PR: #1848

@devinrhode2
Copy link

I'm not able to close, can you try @jan-hudec ?

@cdrage
Copy link
Member

cdrage commented Jun 3, 2024

I'll close! Feel free to try out our newest release with network mode.

@cdrage cdrage closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants