-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for network_mode: service:
*
#1846
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
Comments
jan-hudec
added
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Mar 22, 2024
I think This just saved me the trouble of trying to use kompose, and instead what ill need to do, until this issue is resolved, is try to directly author a pod which runs two containers |
Actually looks like this issue can be closed based on this PR: #1848 |
I'm not able to close, can you try @jan-hudec ? |
I'll close! Feel free to try out our newest release with network mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What would you like to be added?
When a service has
network_mode
of the formservice:
anotherservice, it should be added as a second container into the deployment of anotherservice instead of getting its own deployment. Because this specification means the services will see each other onlocalhost
, which roughly corresponds to being in the same pod in kubernetes.Why is this needed?
I tried to convert https://github.com/dehydr8/elevation-of-privilege/blob/master/docker-compose.yml to Kubernetes, but the resulting manifest can't be used as is, because the two containers are set up so the
client
one, working as reverse proxy forserver
, references the server at three fixed addressesws://localhost:8000
,http://locahost:8001
andhttp://localhost:8002
and if they are started in separate pods, they can't.The text was updated successfully, but these errors were encountered: