feat: require RequiresRepublish for rotation #1124
Conversation
Remove the rotation controller and rely exclusively on RequiresRepublish for secret rotation. All supported k8s versions have RequiresRepublish support enabled by default. Resolves: kubernetes-sigs#585 The flags will be no-ops in this and removed in 1.5+.
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tam7t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/test all |
|
@tam7t: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@tam7t: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
|
Synced with @tam7t on slack. Going to close this PR and i'll open a new one with the changes. /close |
|
@aramase: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The flags will be no-ops in this and removed in 1.5+.
/kind deprecation
What this PR does / why we need it:
Remove the rotation controller and rely exclusively on RequiresRepublish for secret rotation.
All supported k8s versions have RequiresRepublish support enabled by default.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #585
Special notes for your reviewer:
For release we would need to remember to remove the files and update the release notes to instruct that existing rbac permissions be deleted (I'm not sure whether helm has support for deletion of that)
TODOs: