Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected result when combining AnnotationsTransformer with ValueAddTransformer #5794

Open
dippynark opened this issue Nov 3, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@dippynark
Copy link

dippynark commented Nov 3, 2024

What happened?

I am trying to use a kustomize transformer to set a default severity for PrometheusRules and then override this default severity using additional transformers for specific alerts. However, when combining these transformers I get an unexpected result compared to when they are applied individually

What did you expect to happen?

I'd expect each transformer to apply independently so that they can be combined

How can we reproduce it (as minimally and precisely as possible)?

# kustomization.yaml
resources:
  - prometheus-rule.yaml

transformers:
  - transformer-severity-default.yaml
  - transformer-severity-example-bar.yaml
# prometheus-rule.yaml
apiVersion: monitoring.coreos.com/v1
kind: PrometheusRule
metadata:
  name: example
spec:
  groups:
    - name: Example
      rules:
        - alert: ExampleFoo
        - alert: ExampleBar
# transformer-severity-default.yaml
apiVersion: builtin
kind: AnnotationsTransformer
metadata:
  name: severity-default
annotations:
  severity: MAJOR
fieldSpecs:
  - kind: PrometheusRule
    path: spec/groups/rules/annotations
    create: true
# transformer-severity-example-bar.yaml
apiVersion: builtin
kind: ValueAddTransformer
metadata:
  name: severity-example-bar
value: WARNING
targets:
  - selector:
      apiVersion: monitoring.coreos.com/v1
      kind: PrometheusRule
      name: example
    fieldPath: spec/groups/[name=Example]/rules/[alert=ExampleBar]/annotations/severity

Expected output

apiVersion: monitoring.coreos.com/v1
kind: PrometheusRule
metadata:
  name: example
spec:
  groups:
  - name: Example
    rules:
    - alert: ExampleFoo
      annotations:
        severity: MAJOR
    - alert: ExampleBar
      annotations:
        severity: WARNING

Actual output

apiVersion: monitoring.coreos.com/v1
kind: PrometheusRule
metadata:
  name: example
spec:
  groups:
  - name: Example
    rules:
    - alert: ExampleFoo
      annotations:
        severity: WARNING
    - alert: ExampleBar
      annotations:
        severity: WARNING

Confusingly, each transformer works as expected when applied individually (e.g. commenting them out in turn they work correctly)

Kustomize version

v5.5.0

Operating system

MacOS

@dippynark dippynark added the kind/bug Categorizes issue or PR as related to a bug. label Nov 3, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 3, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants