Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow publishing Kueue images prior to merge to the main branch #4310

Open
mimowo opened this issue Feb 19, 2025 · 5 comments
Open

Allow publishing Kueue images prior to merge to the main branch #4310

mimowo opened this issue Feb 19, 2025 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mimowo
Copy link
Contributor

mimowo commented Feb 19, 2025

What would you like to be added:

I would like to be able to push some images prior to the publication to the main branch.

We certainly don't want to push all branches, so I would propose to modify the rules for publishing here using a dedicated entry "^push-prototype-". Users who would want to push their branches would use this prefix to their branch names.

Actually, there is already a workaround by naming the branch with the release- prefix, but it does not capture the intention.

Why is this needed:

To be able to hand an image to a user for testing.

This is inspired by discussions around #4165, but there are other cases where we have a "design partner" and being able to share them an image from branch would be great.

@mimowo mimowo added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 19, 2025
@mimowo
Copy link
Contributor Author

mimowo commented Feb 19, 2025

cc @tenzen-y @gabesaba @dgrove-oss @BenTheElder wdyt?

@mimowo
Copy link
Contributor Author

mimowo commented Feb 19, 2025

Actually, I just realized, looking at the rules, there is already a workaround by naming the branch with the release- prefix, but it does not capture the intention, and I believe this is a valid use-case, not something we need to be "securing" by obfuscation :)

@mimowo
Copy link
Contributor Author

mimowo commented Feb 19, 2025

cc @PBundyra

@tenzen-y
Copy link
Member

Could we prepare a separate dedicated dir or tag prefix something like pre-${IMAGE_HASH}? Because in general, the latest image is recognized as the main branch (merged) image.

@mimowo
Copy link
Contributor Author

mimowo commented Feb 19, 2025

This would be ideal, but not sure how much work this would be. Maybe an acceptable solution which is "in the middle" is to don't push such images with the "latest" tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants