Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imprecise log line: LocalQueue for workload didn't exist #3527

Open
gabesaba opened this issue Nov 13, 2024 · 4 comments · May be fixed by #3605
Open

Imprecise log line: LocalQueue for workload didn't exist #3527

gabesaba opened this issue Nov 13, 2024 · 4 comments · May be fixed by #3605
Assignees
@7h3-3mp7y-m4n
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@gabesaba
Copy link
Contributor

What would you like to be cleaned:
When AddOrUpdateWorkloadWithoutLock returns false, there are several lines which may log that a LocalQueue does not exist

e.g.

kueue/pkg/controller/core/workload_controller.go

Lines 732 to 734 in 2c8e7da

if !r.queues.AddOrUpdateWorkloadWithoutLock(wlCopy) {
log.V(2).Info("LocalQueue for workload didn't exist or not active; ignored for now")
}

Unfortunately, this function can also return false when the ClusterQueue is not located

kueue/pkg/queue/manager.go

Lines 336 to 339 in 2c8e7da

cq := m.hm.ClusterQueues[q.ClusterQueue]
if cq == nil {
return false
}

We should differentiate whether the ClusterQueue or LocalQueue is missing in the log lines which depend on (directly or indirectly) the return value of this function.

Why is this needed:
To assist with future debugging, and to make our logging more precise.
@gabesaba gabesaba added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 13, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 20, 2024

it seems like
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@mimowo:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

it seems like
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 20, 2024
@7h3-3mp7y-m4n
Copy link

I'll pick it up :)

@7h3-3mp7y-m4n 7h3-3mp7y-m4n linked a pull request Nov 20, 2024 that will close this issue
Open
@7h3-3mp7y-m4n
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@7h3-3mp7y-m4n 7h3-3mp7y-m4n

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Log output for LocalQueue and ClusterQueue 7h3-3mp7y-m4n/kueue
4 participants
@mimowo @gabesaba @k8s-ci-robot @7h3-3mp7y-m4n