Use ResourceFlavorReference instead of string consistently

[mimowo]

/kind cleanup

What would you like to be cleaned:

To use ResourceFlavorReference consistently, and only cast to string when absolutly needed

Why is this needed:

For example here:

• flavor is casted ResourceFlavorReference -> string here
• then down in the invocation stack it is casted back from string to ResourceFlavorReference: here

[kannon92]

/good-first-issue
/help wanted

[k8s-ci-robot]

@kannon92:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/help wanted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[shubhamch71]

Hi @mimowo I understand the goal is to consistently use ResourceFlavorReference type instead of string throughout the codebase, particularly in ClusterQueuesUsingFlavor() and related methods, only casting to string when absolutely necessary (like in NamespacedName). Could you help clarify the specific scenarios where casting to string would still be necessary apart from NamespacedName ? Also anything you can suggest to get started with this issue?

[mimowo]

the goal is to consistently use ResourceFlavorReference type instead of string throughout the codebase

yes

Could you help clarify the specific scenarios where casting to string would still be necessary apart from NamespacedName ?

AFAIK only when passing to NamespacedName, but I might be missing some place, it is part of the task to figure out all such places.

Also anything you can suggest to get started with this issue?

I think you are on the right track.

[kaisoz]

/assign

@shubhamch71 I've assigned this one to myself because it's still free and you didn't add any update in some time. However, if you already started with it please let me know.

[shubhamch71]

@kaisoz Thanks for picking this up! I apologize for the delay on my end—I’ve been caught up with work and won’t be able to make further progress on it. Feel free to go ahead and take it forward.

[kaisoz]

@shubhamch71 No worries! I'll work on it, thanks for the response 😊