Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the new event recorder in Kueue #1481

Open
3 tasks
achernevskii opened this issue Dec 18, 2023 · 8 comments · May be fixed by #2675
Open
3 tasks

Switch to the new event recorder in Kueue #1481

achernevskii opened this issue Dec 18, 2023 · 8 comments · May be fixed by #2675
Assignees
@vladikkuzn
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@achernevskii
Copy link
Contributor

What would you like to be added:

#1387 (comment)

Switch from record.EventRecorder to events.EventRecorder, which has extra machine-readable fields.

https://github.com/kubernetes/client-go/blob/84a6fe7e4032ae1b8bc03b5208e771c5f7103549/tools/events/interfaces.go#L29

Why is this needed:

It will be useful to distinguish between a "regular" workload finish (when the job ends) versus another kind of failure, in a machine readable way.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.
@achernevskii achernevskii added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 18, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2024
@tenzen-y
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 28, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 26, 2024
@tenzen-y
Copy link
Member

tenzen-y commented Jul 8, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 8, 2024
@vladikkuzn
Copy link
Contributor

/assign

@vladikkuzn vladikkuzn linked a pull request Jul 22, 2024 that will close this issue
Draft
achernevskii added a commit to achernevskii/kueue that referenced this issue Jul 23, 2024
@achernevskii
WIP try to migrate to events.EventRecorder
b720b43 
* See
  kubernetes-sigs#1387 (comment).

* See kubernetes-sigs#1481.
@mimowo
Copy link
Contributor

mimowo commented Jul 30, 2024

It will be useful to distinguish between a "regular" workload finish (when the job ends) versus another kind of failure, in a machine readable way.

It is not clear to me if this motivation is still valid since we have the reason field indicating Failed / Succeeded since #2026. I would suggest to wait for a proper support of the new interface from the controller-runtime, re-opened the discussion in kubernetes-sigs/controller-runtime#2141.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 28, 2024
@tenzen-y
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladikkuzn vladikkuzn

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from record.EventRecorder to events.EventRecorder epam/kubernetes-kueue
6 participants
@mimowo @k8s-ci-robot @vladikkuzn @k8s-triage-robot @tenzen-y @achernevskii