Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add affinities to calico-typha and calico-kube-controllers #11122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add affinities to calico-typha and calico-kube-controllers #11122

wants to merge 2 commits into from

Conversation

spnngl
Copy link

@spnngl spnngl commented Apr 25, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add needed affinities and pod anti-affinities to calico components

Which issue(s) this PR fixes:

Fixes #11123

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?:

`calico_typha_affinity`: let user add an affinity block to calico-typha deployment if needed
`calico_policy_controller_affinity`: let user add an affinity block to calico-kube-controllers if needed

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: spnngl
Once this PR has been reviewed and has the lgtm label, please assign oomichi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @spnngl. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 25, 2024
@mzaian
Copy link
Contributor

mzaian commented Apr 26, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 26, 2024
@yankay
Copy link
Member

yankay commented May 6, 2024

HI @affinity

The affinities are not the default config in the helm chart.
Should we change it to an optional ansible variable instead of a hardcode jinja2 template?

Another good choice is to promote the change to the upstream: https://github.com/projectcalico/calico. So that the kubespray can change follow by the upstream.

Thanks for the PR

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2024
@spnngl
Copy link
Author

spnngl commented May 6, 2024

Hi @yankay

I just added optional parameters for affinities.
I'll look into their charts later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyclinder cyclinder Awaiting requested review from cyclinder

@VannTen VannTen Awaiting requested review from VannTen

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add needed affinities to calico-typha and calico-kube-controllers
4 participants
@spnngl @k8s-ci-robot @mzaian @yankay