Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arguments in liveness-probe for cinder-csi #11115

Open
jmimico opened this issue Apr 23, 2024 · 0 comments · May be fixed by #11169
Open

Allow arguments in liveness-probe for cinder-csi #11115

jmimico opened this issue Apr 23, 2024 · 0 comments · May be fixed by #11169
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jmimico
Copy link

jmimico commented Apr 23, 2024

What would you like to be added

The ability to add args to cinder_csi_nodeplugin for liveness-probe.

In cinder_csi_nodeplugin.yml.j2

Example:

   - name: liveness-probe
          image: registry.k8s.io/sig-storage/livenessprobe:v2.5.0
          args:
            - "--csi-address=/csi/csi.sock"
            - "--probe-timeout=2s"

Why is this needed

We have found it useful to be able to configure certain 'args' such as --probe-timeout=2s because the default of 1s has been found to be too short for some Cloud API's which have expensive queries and are a bit slow to respond which cause probes to fail and the service to be restarted.

@jmimico jmimico added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant