Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes additional disks with Virtualbox for Vagrant #11091

Merged
merged 1 commit into from May 3, 2024
Merged

Fixes additional disks with Virtualbox for Vagrant #11091

merged 1 commit into from May 3, 2024

Conversation

kri5
Copy link
Contributor

@kri5 kri5 commented Apr 15, 2024

When using the kube_node_instancers_with_disks* variables, there were no configuration block using those to provision disks with the VirtualBox provider.

What type of PR is this?

/kind bug

What this PR does / why we need it:
This PR adds a block to configure disks for virtualbox (was only present for libvirt)

Which issue(s) this PR fixes:
Fixes #11090

NONE

@kri5
Fixes additional disks with Virtualbox for Vagrant
7a210e5 
When using the kube_node_instancers_with_disks* variables, there were
no configuration block using those to provision disks with the
VirtualBox provider.

This commit fixes it.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 15, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @kri5. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2024
@yankay
Copy link
Member

yankay commented Apr 16, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2024
@yankay
Copy link
Member

yankay commented Apr 17, 2024

Thanks @kri5
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kri5, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@VannTen
Copy link
Contributor

VannTen commented May 3, 2024

I don't have a vb setup to test this, but I'm going to say that should be fine. It's new functionality anyway...
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 315cfe1 into kubernetes-sigs:master May 3, 2024
60 checks passed
dabeck pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
@kri5 @dabeck
Fixes additional disks with Virtualbox for Vagrant (kubernetes-sigs#1…
243c8b2 
…1091)

When using the kube_node_instancers_with_disks* variables, there were
no configuration block using those to provision disks with the
VirtualBox provider.

This commit fixes it.
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@kri5 @pedromcpedro
Fixes additional disks with Virtualbox for Vagrant (kubernetes-sigs#1…
8377c26 
…1091)

When using the kube_node_instancers_with_disks* variables, there were
no configuration block using those to provision disks with the
VirtualBox provider.

This commit fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian Awaiting requested review from mzaian

@VannTen VannTen Awaiting requested review from VannTen

Assignees

@VannTen VannTen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional disks not working for VirtualBox provider in Vagrant
4 participants
@kri5 @k8s-ci-robot @yankay @VannTen