Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cilium CNI make limits optional #11051

Open
TlalkaM opened this issue Apr 3, 2024 · 0 comments · May be fixed by #11053
Open

Cilium CNI make limits optional #11051

TlalkaM opened this issue Apr 3, 2024 · 0 comments · May be fixed by #11053
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@TlalkaM
Copy link

TlalkaM commented Apr 3, 2024

What would you like to be added

Variable/variables to disable adding cpu/memory under limits section or whole limit section in the daemonset yaml, eg.

resources:
{% if cilium_enable_cpu_limit or cilium_enable_memory_limit %}
  limits:
{% if cilium_enable_cpu_limit %}
    cpu: {{ cilium_cpu_limit }}
{% endif %}
{% if cilium_enable_memory_limit %}
    memory: {{ cilium_enable_memory_limit }}
{% endif %} 
{% endif %}

This can also be achieved by checking if the cilium_cpu_limit and cilium_memory_limit are defined and changing the default values to {{ undef() }}

Why is this needed

WIth nodes that hosts ~1k pods every node drain causes very high spike in cilium utilization of resources, setting high limits and wasting cpu cycles for limiting cpu for cilium pod seems like workaround :)

@TlalkaM TlalkaM added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 3, 2024
@pbromb pbromb linked a pull request Apr 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant