Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump golang.org/x/net from 0.18.0 to 0.19.0 #2653

Closed
shaneutt opened this issue Dec 7, 2023 · 4 comments · Fixed by #2705
Closed

bump golang.org/x/net from 0.18.0 to 0.19.0 #2653

shaneutt opened this issue Dec 7, 2023 · 4 comments · Fixed by #2705
Assignees
@jayreddy040-510 @Vandit1604
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@shaneutt
Copy link
Member

shaneutt commented Dec 7, 2023

As seen in #2638 there are some failures occurring with dependabot's attempt to update x/net. The purpose of this task is to manually get those updates done.

Similar to #2642, the reason for separating this out into its own issue rather than just doing it is that I realized this actually could probably qualify as a good first issue, since it mostly just requires some Golang knowledge and not deep knowledge of specific Gateway API implementations or anything like that. We never have enough good first issues for the amount of interest that we get in this project. So we'll hang this one out there for a minute and see if any newcomers want it first.
@shaneutt shaneutt added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 7, 2023
@shaneutt shaneutt mentioned this issue Dec 7, 2023
Closed
@jayreddy040-510
Copy link

/assign

@jayreddy040-510
Copy link

@shaneutt hey - thanks for leaving this for newcomers!

i'm navigating the contributing docs and don't see much in the way of manual dependency updates. my instinct is to update the go.mod file - would i do that under gwctl/ as well?

thanks for your help :)

@shaneutt
Copy link
Member Author

shaneutt commented Dec 7, 2023 •
edited
Loading

Thanks for jumping in! Yes that's fine: there are actually 3 go.mod files, check out conformance/echo-basic/go.mod as well. 🖖

@jayreddy040-510 jayreddy040-510 mentioned this issue Dec 8, 2023
Closed
@Vandit1604
Copy link
Contributor

I would like to take a stab on this since it looks like no one is actively working on this.
/assign

@Vandit1604 Vandit1604 mentioned this issue Jan 7, 2024
Merged
@shaneutt shaneutt removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayreddy040-510 jayreddy040-510

@Vandit1604 Vandit1604

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
3 participants
@shaneutt @jayreddy040-510 @Vandit1604