-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLSConfig.mode is "optional", but has no default #2070
Comments
We talked about this in our sync today, we need to do a little more thinking about what we wanna do next with this one, I'll triage it forward: /assign @shaneutt |
Discussed this with the other maintainers, we definitely need some updates here. /triage accepted We need to start by documenting that the unset behavior is dependent on protocol. /kind documentation |
@shaneutt: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Talked about this one in the sync, looks like Terminate IS the default? https://github.com/kubernetes-sigs/gateway-api/blob/bf76bd0499cffa94966a218678bef86aac948943/apis/v1beta1/gateway_types.go#L310C35-L310C35 /assign @robscott |
Confirmed that Terminate is the default, closing this one out. API: gateway-api/apis/v1beta1/gateway_types.go Lines 352 to 353 in d4ff2d4
CRD: gateway-api/config/crd/standard/gateway.networking.k8s.io_gateways.yaml Lines 445 to 446 in d4ff2d4
/close |
Should I make a PR to add this to the docs? This issue was about the docs not stating it. Other optional enum fields explain what missing means. |
@tommie yep, that makes sense, sorry for the confusion here! |
What happened:
Looking at https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1beta1.GatewayTLSConfig, the
mode
is optional, but it is not explained what it means if this is missing.The
certificateRefs
field says:Which suggests that "terminate" is actually the default.
What you expected to happen:
It is clearly stated what happens if the field isn't present.
Anything else we need to know?:
Neither Envoy Gateway nor cert-manager handle "terminate" as the default.
The text was updated successfully, but these errors were encountered: