Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow ManagerOptions to be marshalled #2926

Open
ryanmcnamara opened this issue Aug 13, 2024 · 1 comment
Open

Feature: Allow ManagerOptions to be marshalled #2926

ryanmcnamara opened this issue Aug 13, 2024 · 1 comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ryanmcnamara
Copy link

It would be very nice if the ManagerOptions https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/manager/manager.go#L101 was more easily printable. Example use case: logging on startup to be sure of what config is used.

Using fmt.Sprintf("%#v", options) has been my workaround but it's pretty suboptimal (pointers not followed for example)

Currently using json.Marshal gives an error like

json: unsupported type: func(*rest.Config, *http.Client) (meta.RESTMapper, error)

Failing to marshal this field named MapperProvider

I'd be willing to PR this, what I would do is add the struct tag json:"-" on fields that should not be printed / logged (e.g. MapperProvider) and then use the standard json.Marshal to get my human readable string.

Wanted to gauge interest before making a PR

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants