Is Machine Deletion Phase Hooks still recommanded?

[mogliang]

Hey all,

Just found there isn't public doc for this feature Machine Deletion Phase Hooks, only a proposal exists https://github.com/kubernetes-sigs/cluster-api/blob/b7b53ca55c82d8ec39c552a24d6c308076c5bd24/docs/proposals/20200602-machine-deletion-phase-hooks.md

Not sure if this feature is still recommanded to use nowadays?

background

we are writing k3s controlplane provider, we need remove etcd member AFTER node drain operation. So want to utilize Machine Deletion Phase Hooks to remove etcd.

[sbueringer]

The current supported way for pre-drain and pre-terminate hooks is to use these annotations:

cluster-api/api/v1beta1/machine_types.go

Lines 54 to 64 in e0c9cdb

	// PreDrainDeleteHookAnnotationPrefix annotation specifies the prefix we
	// search each annotation for during the pre-drain.delete lifecycle hook
	// to pause reconciliation of deletion. These hooks will prevent removal of
	// draining the associated node until all are removed.
	PreDrainDeleteHookAnnotationPrefix = "pre-drain.delete.hook.machine.cluster.x-k8s.io"
	// PreTerminateDeleteHookAnnotationPrefix annotation specifies the prefix we
	// search each annotation for during the pre-terminate.delete lifecycle hook
	// to pause reconciliation of deletion. These hooks will prevent removal of
	// an instance from an infrastructure provider until all are removed.
	PreTerminateDeleteHookAnnotationPrefix = "pre-terminate.delete.hook.machine.cluster.x-k8s.io"