Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support installing "latest" EKS addon #5184

Open
richardcase opened this issue Oct 25, 2024 · 4 comments · May be fixed by #5210
Open

Support installing "latest" EKS addon #5184

richardcase opened this issue Oct 25, 2024 · 4 comments · May be fixed by #5210
Assignees
@thiha-min-thant
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@richardcase
Copy link
Member

/kind feature

Describe the solution you'd like

Currently when you specify EKS addons to be installed in AWSManagedControlPlane you need to specify the specific version of the addon. It would also be good to support installing the latest supported version of the addon.

So currently you need to do:

  spec:
    addons:
    - conflictResolution: overwrite
      name: vpc-cni
      version: v1.18.1-eksbuild.3

But it would also be nice to support the following:

  spec:
    addons:
    - conflictResolution: overwrite
      name: vpc-cni
      version: latest

If latest is specified then we need to query for the latest supported version for the cluster/k8s version (using DescribeAddonVersions) and use that.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 25, 2024
@richardcase
Copy link
Member Author

/triage accepted
/priority important-longterm
/help

@k8s-ci-robot
Copy link
Contributor

@richardcase:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted
/priority important-longterm
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Oct 25, 2024
@thiha-min-thant
Copy link

Hi @richardcase , could you please assign to me? Thanks!

@richardcase
Copy link
Member Author

Sure, thanks @thiha-min-thant

/assign thiha-min-thant

@thiha-min-thant thiha-min-thant linked a pull request Nov 7, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thiha-min-thant thiha-min-thant

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
3 participants
@richardcase @thiha-min-thant @k8s-ci-robot