Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

сifs client unable to mount SMB share without nosharesock mount option if current TCP connection dead #767

Open
dudniksergei opened this issue Apr 4, 2024 · 3 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@dudniksergei
Copy link

What happened: I tested this manually from the smb-csi driver pod. The CIFS client is unable to mount the SMB share without the 'nosharesock' mount option. It attempts to reuse an established connection to the Samba share. However, if this connection is dead, the CIFS client fails to mount the SMB share. Adding the 'nosharesock' mount option creates a new TCP connection, allowing the SMB share to be mounted successfully

I tested it from csi-node pod

  1. We have 5 TCP connections to SAMBA server
    sh-4.4# ss -na| grep 10.81.X.X
    tcp TIME-WAIT 0 0 10.82.72.60:55422 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:963 10.81.X.X:2049

tcp ESTAB 0 0 10.82.72.60:52514 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:43158 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:59186 10.81.X.X:445

  1. Mount without nosharesock option failed because current TCP connectios are dead ( for some reason, for example network firewall ).

sh-4.4# mount --verbose -t cifs -o file_mode=0770,dir_mode=0770,username=user,vers=3.0,password="XXXXXXXX" //10.81.X.X/share /var/mnt1
mount error(5): Input/output error
Refer to the mount.cifs(8) manual page (e.g. man mount.cif

  1. mount CIFS share with nosharesock option. It works because new connection was created

sh-4.4# mount --verbose -t cifs -o nosharesock,file_mode=0770,dir_mode=0770,username=user,vers=3.0,password="XXXXXXXX" //10.81.X.X/share /var/mnt1
mount.cifs kernel mount options: ip=10.81.X.X,unc=//10.81.X.X/share,nosharesock,file_mode=0770,dir_mode=0770,vers=3.0,user=user,pass=********

  1. we have new TCP connection ( source port 51776)
    sh-4.4# ss -na| grep 10.81.X.X

tcp TIME-WAIT 0 0 10.82.72.60:55422 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:963 10.81.X.X:2049

tcp ESTAB 0 0 10.82.72.60:52514 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:43158 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:51776 10.81.X.X:445

tcp ESTAB 0 0 10.82.72.60:59186 10.81.X.X:445

What you expected to happen:

cifs.client creates additional TCP connection if the current conection is dead.

How to reproduce it:

This can be reproduced manually with the CIFS.Client package and a Samba server. Create two shares in the SMB server. Mount the first share, check TCP connection state from the client, then block this connection (using a firewall, for example). Afterward, try to mount the second share.

Anything else we need to know?:
This is behavior cifs.client.

Environment:

  • CSI Driver version: v0.7.0
  • Kubernetes version (use kubectl version): 1.25
  • OS (e.g. from /etc/os-release): CoreOS 4.12
  • Kernel (e.g. uname -a): 4.14.0-372.76.1.el8_6.x86_64
  • Install tools:
  • Others: cifs.client version 6.8
@andyzhangx
Copy link
Member

I think this is what nosharesock mount option is used for: don't use existing connection, always create a new connection in the smb mount.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants