Skip to content

Commit bae225e

Browse files
committed
chore: reference ghcr.io images in workspacekind yaml
Given we have migrated all our images from docker.io to ghcr.io - our `notebooks-v2` branch should reference the "proper" container registry. This commit updates the code to use: - `ghcr.io/kubeflow/kubeflow/notebook-servers` Affected areas: - `jupyterlab_scipy_180` and `jupyterlab_scipy_190` `imageConfig` entries - various test files Signed-off-by: Andy Stoneberg <[email protected]>
1 parent 6123650 commit bae225e

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

workspaces/backend/api/suite_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ func NewExampleWorkspaceKind(name string) *kubefloworgv1beta1.WorkspaceKind {
312312
},
313313
},
314314
Spec: kubefloworgv1beta1.ImageConfigSpec{
315-
Image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.8.0",
315+
Image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.8.0",
316316
Ports: []kubefloworgv1beta1.ImagePort{
317317
{
318318
Id: "jupyterlab",
@@ -337,7 +337,7 @@ func NewExampleWorkspaceKind(name string) *kubefloworgv1beta1.WorkspaceKind {
337337
},
338338
},
339339
Spec: kubefloworgv1beta1.ImageConfigSpec{
340-
Image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.9.0",
340+
Image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.9.0",
341341
Ports: []kubefloworgv1beta1.ImagePort{
342342
{
343343
Id: "jupyterlab",

workspaces/controller/api/v1beta1/workspacekind_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ type ImageConfigValue struct {
318318
type ImageConfigSpec struct {
319319
// the container image to use
320320
// +kubebuilder:validation:MinLength:=2
321-
// +kubeflow:example="docker.io/kubeflownotebookswg/jupyter-scipy:v1.7.0"
321+
// +kubeflow:example="ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.7.0"
322322
Image string `json:"image"`
323323

324324
// the pull policy for the container image

workspaces/controller/config/samples/jupyterlab_v1beta1_workspacekind.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ spec:
271271
spec:
272272
## the container image to use
273273
##
274-
image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.8.0"
274+
image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.8.0"
275275

276276
## the pull policy for the container image
277277
## - default: "IfNotPresent"
@@ -301,7 +301,7 @@ spec:
301301
- key: "python_version"
302302
value: "3.11"
303303
spec:
304-
image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.9.0"
304+
image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.9.0"
305305
imagePullPolicy: "IfNotPresent"
306306
ports:
307307
- id: "jupyterlab"

workspaces/controller/internal/controller/suite_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ func NewExampleWorkspaceKind1(name string) *kubefloworgv1beta1.WorkspaceKind {
288288
},
289289
},
290290
Spec: kubefloworgv1beta1.ImageConfigSpec{
291-
Image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.8.0",
291+
Image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.8.0",
292292
Ports: []kubefloworgv1beta1.ImagePort{
293293
{
294294
Id: "jupyterlab",
@@ -313,7 +313,7 @@ func NewExampleWorkspaceKind1(name string) *kubefloworgv1beta1.WorkspaceKind {
313313
},
314314
},
315315
Spec: kubefloworgv1beta1.ImageConfigSpec{
316-
Image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.9.0",
316+
Image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.9.0",
317317
Ports: []kubefloworgv1beta1.ImagePort{
318318
{
319319
Id: "jupyterlab",

workspaces/controller/internal/webhook/suite_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ func NewExampleWorkspaceKind(name string) *kubefloworgv1beta1.WorkspaceKind {
276276
},
277277
},
278278
Spec: kubefloworgv1beta1.ImageConfigSpec{
279-
Image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.8.0",
279+
Image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.8.0",
280280
Ports: []kubefloworgv1beta1.ImagePort{
281281
{
282282
Id: "jupyterlab",
@@ -301,7 +301,7 @@ func NewExampleWorkspaceKind(name string) *kubefloworgv1beta1.WorkspaceKind {
301301
},
302302
},
303303
Spec: kubefloworgv1beta1.ImageConfigSpec{
304-
Image: "docker.io/kubeflownotebookswg/jupyter-scipy:v1.9.0",
304+
Image: "ghcr.io/kubeflow/kubeflow/notebook-servers/jupyter-scipy:v1.9.0",
305305
Ports: []kubefloworgv1beta1.ImagePort{
306306
{
307307
Id: "jupyterlab",

0 commit comments

Comments
 (0)