fix php 8.2 string interpolation warnings

Using ${var} in strings is deprecated, use {$var} instead [1]

[1]: https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation

Author: ktomk

CHANGELOG.md

@@ -11,10 +11,13 @@ The format is based on [Keep a Changelog] and Pipelines adheres to
 ### Add
 - PHP 8.2 Alpine based build container
 ### Fix
+- PHP 8.2 Using ${var} in strings deprecations (#24) (thanks
+  [Brad Kent][Brad Kent])
 - Eager substr_replace() use in updateTimestamps() (thanks [Jan Tvrdík])
 - Fix type annotation and add support for DateTimeImmutable (thanks
   [Jordi Boggiano])
 
+[Brad Kent]: https://github.com/bkdotcom
 [Jan Tvrdík]: https://github.com/JanTvrdik
 [Jordi Boggiano]: https://github.com/Seldaek
 

lib/build/coverage-checker.php

@@ -50,7 +50,7 @@
     $fMetrics = function ($s) use ($xml) {
         return array_sum(array_map(
             'intval',
-            $xml->xpath(".//metrics/@${s}elements")
+            $xml->xpath(".//metrics/@{$s}elements")
         ));
     };
 

src/Cli/Docker/ProcessManager.php

@@ -36,7 +36,7 @@ public function findAllContainerIdsByName($name)
             'docker',
             array(
                 'ps', '--no-trunc', '-qa', '--filter',
-                "name=^/\\Q${name}\\E$",
+                "name=^/\\Q{$name}\\E$",
             ),
             $result
         );
@@ -150,7 +150,7 @@ private function psPrefixImpl($prefix, $all = false)
             'docker',
             array(
                 'ps', '-q' . ($all ? 'a' : ''), '--no-trunc', '--filter',
-                "name=^/${prefix}[-.]",
+                "name=^/{$prefix}[-.]",
             ),
             $result
         );

src/Cli/Exec.php

@@ -49,7 +49,7 @@ public function pass($command, array $arguments)
         }
 
         ':' === $buffer ? $status = 0 : passthru($buffer, $status);
-        $this->debug("exit status: ${status}");
+        $this->debug("exit status: {$status}");
 
         return $status;
     }
@@ -80,7 +80,7 @@ public function capture($command, array $arguments, &$out = null, &$err = null)
 
         $proc = new Proc($buffer);
         $status = $proc->run();
-        $this->debug("exit status: ${status}");
+        $this->debug("exit status: {$status}");
         $out = $proc->getStandardOutput();
         $err = $proc->getStandardError();
 

src/File/Definitions/Caches.php

@@ -92,15 +92,15 @@ private function parse(array $array)
     {
         foreach ($array as $name => $path) {
             if (!is_string($name)) {
-                throw new ParseException("cache definition invalid cache name: ${name}");
+                throw new ParseException("cache definition invalid cache name: {$name}");
             }
 
             if (null === $path) {
-                throw new ParseException("cache '${name}' should be a string value (it is currently null or empty)");
+                throw new ParseException("cache '{$name}' should be a string value (it is currently null or empty)");
             }
 
             if (is_bool($path)) {
-                throw new ParseException("cache '${name}' should be a string (it is currently defined as a boolean)");
+                throw new ParseException("cache '{$name}' should be a string (it is currently defined as a boolean)");
             }
 
             // Fixme(tk): more importantly is that $path is not array or object

src/File/Definitions/Service.php

@@ -100,10 +100,10 @@ private function parseVariables(array $array)
 
         foreach ($variables as $name => $value) {
             if (null === $value) {
-                throw new ParseException("variable ${name} should be a string value (it is currently null or empty)");
+                throw new ParseException("variable {$name} should be a string value (it is currently null or empty)");
             }
             if (is_bool($value)) {
-                throw new ParseException("variable ${name} should be a string (it is currently defined as a boolean)");
+                throw new ParseException("variable {$name} should be a string (it is currently defined as a boolean)");
             }
         }
 

src/File/Pipeline/StepParser.php

@@ -89,7 +89,7 @@ private function parseAfterScript(array $step)
     private function parseNamedScript($name, array $script)
     {
         if (!is_array($script[$name]) || !count($script[$name])) {
-            throw new ParseException("'${name}' requires a list of commands");
+            throw new ParseException("'{$name}' requires a list of commands");
         }
 
         foreach ($script[$name] as $index => $line) {

src/File/Pipelines.php

@@ -237,7 +237,7 @@ private function parseValidatePipelines(array $array)
         if (!$count && !isset($array['default'])) {
             $middle = implode(', ', array_slice($sections, 0, -1));
 
-            throw new ParseException("'pipelines' requires at least a default, ${middle} or custom section");
+            throw new ParseException("'pipelines' requires at least a default, {$middle} or custom section");
         }
     }
 
@@ -259,7 +259,7 @@ private function referencesDefault(array &$array)
         }
 
         if (!is_array($array[$default])) {
-            throw new ParseException("'${default}' requires a list of steps");
+            throw new ParseException("'{$default}' requires a list of steps");
         }
 
         $references[$default] = array($default, null, &$array[$default]);
@@ -285,10 +285,10 @@ private function referencesAddSections(array $references, array &$array)
                 continue; // not a section for references
             }
             if (!is_array($refs)) {
-                throw new ParseException("'${section}' requires a list");
+                throw new ParseException("'{$section}' requires a list");
             }
             foreach ($refs as $pattern => $pipeline) {
-                $references["${section}/${pattern}"] = array(
+                $references["{$section}/{$pattern}"] = array(
                     (string)$section,
                     (string)$pattern,
                     &$array[$section][$pattern],

src/File/PipelinesReferences.php

@@ -130,7 +130,7 @@ private static function idNonPatternMatch(Pipelines $pipelines, $section, $refer
 
         # check for direct (non-pattern) match
         if (isset($pipelines->array[$section][$reference])) {
-            return array(true, "${section}/${reference}");
+            return array(true, "{$section}/{$reference}");
         }
 
         return array(false, null);
@@ -158,6 +158,6 @@ private static function idPattern(Pipelines $pipelines, $section, $reference)
             }
         }
 
-        return array('' !== $match, "${section}/${match}");
+        return array('' !== $match, "{$section}/{$match}");
     }
 }

src/Lib.php

@@ -105,7 +105,7 @@ public static function quoteArg($argument)
         foreach ($parts as $index => $part) {
             $index && $buffer .= "\\'";
             $safe = preg_match('~^[a-zA-Z0-9,._+@%/-]*$~D', $part);
-            $buffer .= $safe ? $part : "'${part}'";
+            $buffer .= $safe ? $part : "'{$part}'";
         }
 
         if ('' === $buffer) {