Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin options in script don't make it into packaging #365

Open
vsajip opened this issue Jun 10, 2022 · 3 comments
Open

Kotlin options in script don't make it into packaging #365

vsajip opened this issue Jun 10, 2022 · 3 comments

Comments

@vsajip
Copy link
Contributor

vsajip commented Jun 10, 2022

This line
https://github.com/holgerbrandl/kscript/blob/dc827753adf707cf31cd220716e85139cae2d9cd/src/main/kotlin/kscript/app/code/GradleTemplates.kt#L44
fails to pick up Kotlin options declared like this:
https://github.com/holgerbrandl/kscript/blob/dc827753adf707cf31cd220716e85139cae2d9cd/test/resources/package_example.kts#L1

I see that the Script has these two fields:
https://github.com/holgerbrandl/kscript/blob/dc827753adf707cf31cd220716e85139cae2d9cd/src/main/kotlin/kscript/app/model/Script.kt#L21-L22
However the kotlinOpts seems not to be used, at least in the Gradle template generation, How come?

@vsajip
Copy link
Contributor Author

vsajip commented Jun 10, 2022

Also, I can't see how the original Gradle capsule plugin would have got the information (like the -Xmx setting). Any pointers?

@aartiPl
Copy link
Collaborator

aartiPl commented Jun 10, 2022

Some small improvements are already in 4.1 branch. Please have a look.

@vsajip
Copy link
Contributor Author

vsajip commented Jun 10, 2022

I compared branches - there's little to no overlap. Anyway, I've updated my code to pick up those flags now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants