You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would certainly not be opposed to that, because the use of adaflo as a library, which is a typical use case, should make sure to not enter the global namespace. I thus agree with this suggestion. I can look into it next week, or you can provide a suggestion and we see how to proceed from there. I would be happy to help.
In a student project, we use
adaflo
and the deal.IITimeStepping
class (https://www.dealii.org/current/doxygen/deal.II/classTimeStepping_1_1TimeStepping.html). Since adaflo also has aTimeStepping
class (see https://github.com/kronbichler/adaflo/blob/master/include/adaflo/time_stepping.h), we get a naming collision. @kronbichler would you agree, if we introduced anadaflo
namespace around the whole code? It's a big incompatibility change, but it would help avoid naming collisions in the future.@j-brotz FYI
The text was updated successfully, but these errors were encountered: