Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce namespace adaflo #86

Open
mschreter opened this issue Apr 24, 2024 · 2 comments
Open

Introduce namespace adaflo #86

mschreter opened this issue Apr 24, 2024 · 2 comments

Comments

@mschreter
Copy link
Collaborator

mschreter commented Apr 24, 2024

In a student project, we use adaflo and the deal.II TimeStepping class (https://www.dealii.org/current/doxygen/deal.II/classTimeStepping_1_1TimeStepping.html). Since adaflo also has a TimeStepping class (see https://github.com/kronbichler/adaflo/blob/master/include/adaflo/time_stepping.h), we get a naming collision. @kronbichler would you agree, if we introduced an adaflo namespace around the whole code? It's a big incompatibility change, but it would help avoid naming collisions in the future.

@j-brotz FYI

@kronbichler
Copy link
Owner

I would certainly not be opposed to that, because the use of adaflo as a library, which is a typical use case, should make sure to not enter the global namespace. I thus agree with this suggestion. I can look into it next week, or you can provide a suggestion and we see how to proceed from there. I would be happy to help.

@mschreter
Copy link
Collaborator Author

That's good to hear. We are happy to contribute and will prepare a suggestion for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants