Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed code quality issues #85

Merged
merged 2 commits into from
Apr 18, 2020
Merged

fixed code quality issues #85

merged 2 commits into from
Apr 18, 2020

Conversation

LuGO0
Copy link
Contributor

@LuGO0 LuGO0 commented Apr 5, 2020

fixed almost all the code quality issues pertaining to the library.the quality issues which remain are pertaining to documentation of readme ,bugReport and similar files.

Issue that this pull request solves

Fixes: #84

Proposed changes

Brief description of what is fixed or changed

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@LuGO0
Copy link
Contributor Author

LuGO0 commented Apr 5, 2020

@krharsh some of which require some design decisions to make in which I need your help please review the changes!!

@LuGO0
Copy link
Contributor Author

LuGO0 commented Apr 5, 2020 •
edited
Loading

and for the remaining code quality issues which are mainly in documentation part of the project which I think would be better handled by the people who created them since It would be a lot easier for them to fix those issues !!

@krharsh17
Copy link
Owner

There are 3 new issues created by this PR, fix them, please.

@LuGO0
Copy link
Contributor Author

LuGO0 commented Apr 6, 2020 •
edited
Loading

@krharsh17 fixed the 3 new codacy warnings!! review please.

LuGO0 added 2 commits April 16, 2020 21:51
@LuGO0
fixed code quality issues
c617b17 
fixed almost all the code quality issues pertaining to the library!!
@LuGO0
reformat code and fixed codacy warnings
2fa7982
krharsh17
krharsh17 approved these changes Apr 18, 2020
View reviewed changes
Copy link
Owner

@krharsh17 krharsh17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@krharsh17 krharsh17 merged commit 30d1bf5 into krharsh17:develop Apr 18, 2020
@krharsh17 krharsh17 added documentation Improvements or additions to documentation enhancement New feature or request gssoc20 medium labels Apr 18, 2020
@krharsh17 krharsh17 added this to the PHASE-2 GS20 milestone Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krharsh17 krharsh17 krharsh17 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request gssoc20 library-update medium sample-update
Projects
None yet
Milestone
PHASE-2 GS20
Development

Successfully merging this pull request may close these issues.

Improve code quality
2 participants
@LuGO0 @krharsh17