Skip to content
This repository has been archived by the owner on Sep 29, 2020. It is now read-only.

Update to latest Electron fixing security issues #9

Open
wants to merge 140 commits into
base: master
Choose a base branch
from

Conversation

mountainash
Copy link

Changing from the current master v1.6.11 of Electron to v9.1.0

mountainash and others added 22 commits March 22, 2020 11:59
 - added meta data to the `package.json`
Downgraded Electon to 3.1.13 probably as webview is to strict these days (for a reason)
 - until they can be fixed again
- Disabled New Section

Related to: kreativgebiet#6
- hiding some over sell
- Fixed: kreativgebiet#4
- until hooked back up again

Releated: kreativgebiet#6
- removed 'electron-store'
- added 'electron-config'
- commenting out all the unused "vibrancy" stuff
- hiding new upgrade button
- removed yarn.lock
Copy link
Contributor

@iduuck iduuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thanks for your contribution. Really stoked since this is a super old project of us, bringing it back to live again.

Secondly, I find a little confusing that everything is just commented out. Please remove the files you don't want to use anymore.

@iduuck
Copy link
Contributor

iduuck commented Jul 17, 2020

On another note, what I found to pull Taskana out of it's competitors is, that there is no actual "title bar", so I would like to see this, too.

@mountainash
Copy link
Author

Secondly, I find a little confusing that everything is just commented out. Please remove the files you don't want to use anymore.

I left it there like a TODO incase someone want to get it working again - but I'm more than happy to delete it all.

@mountainash
Copy link
Author

mountainash commented Jul 19, 2020

what I found to pull Taskana out of it's competitors is, that there is no actual "title bar", so I would like to see this, too.

I don't think it would be that usable without the title bar with the current design of Asana. It might have worked well when Asana looked like this:
Taskana Tasks sample image

But I can't see it looking/working better for the current Asana design:

Taskana Tasks sample image

@mountainash mountainash mentioned this pull request Jul 19, 2020
@mountainash
Copy link
Author

I've created a new Issue for the title bar "debate". #10

Big bunch of dependency updates
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants