Fix msgspec template to add field #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbuss
force-pushed
the
retain-ordering-of-fields-with-snake-casing
branch
from
566fb56
to
cf683e4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1942 +/- ##
=======================================
Coverage ? 98.90%
=======================================
Files ? 37
Lines ? 4186
Branches ? 973
=======================================
Hits ? 4140
Misses ? 29
Partials ? 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #1942 will not alter performanceComparing Summary
|
ianbuss
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tests/data/expected/main/main_use_annotated_with_msgspec_meta_constraints/output.py
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With msgspec outputs, the order of generated fields sometimes results in invalid class definitions, with required and optional fields in the wrong order. Additionally, if using
--snake-case-field, field aliases are not added.This PR contains the following fixes:
_has_field_assignmentsort function is modified to sort optional fields last__str__function for msgspec fields is updated to add an explicitNonedefault for optional fields when no other default has been set.field.fieldfor annotated types.test_main.py.Fixes #1943
Fixes #1919
Fixes #1920