New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newlisp.c:5839]: (style) Suspicious condition #8

Open

dcb314 opened this issue Sep 27, 2016 · 1 comment

dcb314 commented Sep 27, 2016

newlisp.c:5839]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

if((intFlag = ((CELL *)cell->next)->next == nilCell))

Maybe better code

if((intFlag = ((CELL *)cell->next)->next) == nilCell)

GerHobbelt commented Feb 3, 2024

if((     intFlag =      (  ((CELL *)cell->next)->next == nilCell   )      ))

(extra whitespace for clarity.)

GerHobbelt added a commit to GerHobbelt/newlisp that referenced this issue


https://github.com/kosh04/newlisp/issues/8

5dd61fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment