Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] make use of batch/mid resource of node capacity #1969

Open
j4ckstraw opened this issue Mar 22, 2024 · 2 comments
Open

[proposal] make use of batch/mid resource of node capacity #1969

j4ckstraw opened this issue Mar 22, 2024 · 2 comments
Labels
kind/proposal Create a report to help us improve

Comments

@j4ckstraw
Copy link
Contributor

What is your proposal:
Change capacity of batch/mid resource to node capacity * reclaimThreshold to make use of capacity field.

https://github.com/koordinator-sh/koordinator/blob/main/pkg/slo-controller/noderesource/plugins/batchresource/plugin.go#L147

Why is this needed:

Is there a suggested solution, if so, please add it:

@j4ckstraw j4ckstraw added the kind/proposal Create a report to help us improve label Mar 22, 2024
@zwzhang0107
Copy link
Contributor

I agree with you that capacity and allocatable may not be same for batch and mid; besides, I think we need to give the definition about the gap between capacity and allocatable(maybe batch reservation?)

@j4ckstraw
Copy link
Contributor Author

In the beginning, I want to use the capacity to solve Cluster Autoscaler(CA) problem.
when pod pending CA will scale out new node to satisfy user requests, it will select one node randomly from the cluster, use the allocatable of the node to calculate how many new node needed.
Because the allocatable is always changing, so I want to make capacity be stable to solve the CA problem.

So I think the capacity of batch should be this: node capacity * reclaim threshold - reserved, which means the max resource can be used for batch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/proposal Create a report to help us improve
Projects
None yet
Development

No branches or pull requests

2 participants