Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2.7 (and 3.5) #75

Closed
jugmac00 opened this issue Nov 8, 2020 · 4 comments · Fixed by #79
Closed

Drop support for Python 2.7 (and 3.5) #75

jugmac00 opened this issue Nov 8, 2020 · 4 comments · Fixed by #79

Comments

@jugmac00
Copy link
Collaborator

jugmac00 commented Nov 8, 2020

The build currently breaks on Python 2.7, as a transitive dep is no longer Python 2.7 compatible.

While we could pin the dependency, maybe it is about time to move forward?

@petri
Copy link
Member

petri commented Nov 22, 2020

Yes, why not. Anyone needing Python2 support will be able to just use 1.3.1.

@petri
Copy link
Member

petri commented Nov 22, 2020

Builds pass again. Metadata, build configs and docs changed to indicate Python3 only status from now on. There's things we still could & should do I am sure so not closing this yet.

But since some badges use pypi as a source of truth, should preferably push a release sooner rather than later.

@jugmac00
Copy link
Collaborator Author

I have a bit of spare time tomorrow. I will look into this. Also, I'd like to run https://github.com/asottile/pyupgrade on the source code.

What is your take on support for Python 3.5? It is EOL since September. Python 3.6 brought f-strings, and also typing (#50) is more convenient with Python 3.6+ as then type annotations for variables were introduced.

@petri
Copy link
Member

petri commented Nov 22, 2020

What is your take on support for Python 3.5? It is EOL since September. Python 3.6 brought f-strings, and also typing (#50) is more convenient with Python 3.6+ as then type annotations for variables were introduced.

I would say let's require 3.6+ while we're at it.

@petri petri changed the title Drop support for Python 2.7 Drop support for Python 2.7 (and 3.5) Nov 22, 2020
@petri petri closed this as completed in #79 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants