Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options values #75

Closed
wants to merge 3 commits into from
Closed

Options values #75

wants to merge 3 commits into from

Conversation

cunhazera
Copy link
Contributor

Fixes #23

Is it what you guys mean?

Copy link
Contributor

@aweigold aweigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission!

That said, this isn't quite what is meant in #23 , but I can understand that the issue as it's written in #23 is "hard to understand".

Where this stems from I think I better described in https://github.com/Kentico/cloud-generators-java/issues/15 .

Ultimately, the two ways to fix this are either or both:

  • Additional helpers injected into dynamic model generation from the generator project.
  • New annotations available for the StronglyTypedModel bindings, something (but not necessarily) like this:
@ContentItemMapping("product")
public class Product {
  @ElementMapping("product_categories")
  List<Option> productCategories;

  //New feature
  @ElementMappingOption(elementCodeName = "product_categories", optionCodeName = "footwear")
  Boolean isFootwear;
}

@Simply007
Copy link
Contributor

Hey @cunhazera,

we would like to thank you for contributing to Kentico's open-source project. As a sign of our appreciation, we would like to send you some Kentico Developer Community SWAG!

Please fill out your postal address if you are interested.

This comment was automatically generated. If you've submitted more than one pull request, it's OK to fill out the form just once.

Kentico Developer Community

If there’s anything we can do to help, please don’t hesitate to reach out to us at [email protected]

@cunhazera
Copy link
Contributor Author

@Simply007 oh, that's great! Second year in a row :)

I have just filled the form.

@makma
Copy link

makma commented Jan 3, 2019

Is this still valid? Are you guys going to finish this one? Thanks.

@petrsvihlik petrsvihlik closed this Jan 9, 2019
@cunhazera
Copy link
Contributor Author

@Simply007 I'm sorry to tell you, but one year has gone and the postal service from Brazil did not deliver what you sent.

@Simply007
Copy link
Contributor

@cunhazera - I am sorry about it. It is hard to handle all of the packages. We had some issues with delivering packages out of the continent.

Is there any chance you are visiting the Czech Republic?

@cunhazera
Copy link
Contributor Author

@Simply007 no chance :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strongly Typed Content Item Converter does not support mapping name from an Option
5 participants