-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback needed: People are omitting ITypeProvider registration #239
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
We receive a lot of various error reports (on StackOverflow, GitHub, support chat on intercom) that all have one common denominator: they are caused by a missing registration of the
ITypeProvider
implementation.There are more ways to register the implementation and they are described here: https://github.com/Kentico/kontent-delivery-sdk-net/wiki/Working-with-strongly-typed-models#adding-support-for-runtime-type-resolution
For simplicity (and historical reasons), the registration is not included in the README (so probably a lot of people miss it at that point).
The fact is that the
ITypeProvider
is not required for the simplest scenarios such as retrieving a 1st level model without complex types. However, for anything more complex (linked items, rich text, etc.) it absolutely necessary to have it registered.Proposed solution
We have a few options:
ITypeProvider
mandatory and throw an exception if omittedYour opinion
Let us know what would be an appropriate solution for you (if you were a new user of the SDK).
The text was updated successfully, but these errors were encountered: