Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiplatform setup #63

Closed
wants to merge 12 commits into from
Closed

Multiplatform setup #63

wants to merge 12 commits into from

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Mar 11, 2019 •
edited

Disclaimer

This is still WIP. I've opened it to let people know I'm working on this. Any feedback is appreciated.

Notes

First attempt to create a multiplatform project.

Currently revisited modules:

  • abi
  • base58
  • bip32
  • bip39
  • bip39_wordlist_en
  • bip39_wordlist_es
  • bip39_wordlist_fr
  • bip39_wordlist_it
  • bip39_wordlist_ja
  • bip39_wordlist_ko
  • bip39_wordlist_zh-Hans
  • bip39_wordlist_zh-Hant
  • bip44
  • blockscout
  • contract_abi_types
  • crypto
  • crypto_api
  • crypto_impl_java_provider
  • crypto_impl_bouncycastle
  • crypto_impl_spongycastle
  • erc55
  • erc67
  • eip155
  • eip191
  • erc681
  • erc831
  • erc961
  • erc1328
  • Woretherscan
  • functions
  • hashes
  • keccak_shortcut
  • keystore
  • method_signatures
  • model
  • networks
  • ripemd160
  • rlp
  • rpc
  • test_data
  • uri_common
  • wallet

Missing modules to revisit:

  • None

Related issues

Closes #22
Closes #31
Closes #61
Closes #62

@RiccardoM
Added spanish, french, italian, japanese, korean, chinese simplified …
25813b8 
…and chinese traditional DIP39 word lists
@RiccardoM
Setting up the multiplatform project following the Ktor example
5f7b31b
@RiccardoM
Reworked some more modules
a4e01eb
@RiccardoM
Started working on the implementation of the methods to remove all th…
467a5d2 
…e Java code
@RiccardoM
Fixed errors and improved modules
eb4173a 
- Fixed the errors inside the following modules
   - bip39_wordlist_es
   - bip39_wordlist_it
   - bip39_wordlist_ja
   - bip39_wordlist_ko
   - abi
   - base58
   - bip39
   - bip44
   - model
 - Deleted the module extensions and moved the code inside model due to the impossibility of having circular dependencies in common modules
@RiccardoM
Revisited some more modules
f4f5151
@RiccardoM
Working on the Crypto section
18a5e0d
@RiccardoM
Converted some more modules to multiplatform architecture
16a205d
@RiccardoM
Converted more modules to multiplatform architecture
d1c2a08
@RiccardoM
Merge branch 'master' of https://github.com/walleth/kethereum into mu…
a255072 
…ltiplatform-setup
@RiccardoM
Completed the multiplatform conversion
db2d4e7
@RiccardoM
Copy link
Contributor Author

RiccardoM commented Mar 13, 2019 •
edited

@ligi The conversion is 99% done. We need to change the CI in order to execute the gradle check command to test everything automatically. Also there are some tests that are failing due to some errors. Can we look at them and try to fix them?

Note. In order to make this library 100% multiplatform, I had to copy/paste the Walleth/HEX and Wallet/SHA3 classes inside the project. To make them usable by this library, we need to convert them to multiplatform too.

@ligi
Copy link
Member

ligi commented Mar 19, 2019

We need to change the CI in order to execute the gradle check command to test everything automatically.

this is as easy as adding a "check" to "stages" in here:
https://github.com/walleth/kethereum/blob/master/.ci/kontinuum.json

but what would it execute more than ./gradlew test is doing

Can we look at them and try to fix them?

am currently quite busy - so if I need to have a look it will take some time

Note. In order to make this library 100% multiplatform, I had to copy/paste the Walleth/HEX and Wallet/SHA3 classes inside the project. To make them usable by this library, we need to convert them to multiplatform too.

is there really no other way? this would be quite ugly imho - perhaps a subproject? Really hope there is another way

@RiccardoM
Copy link
Contributor Author

@ligi Understanding that you have not much time in order to maintain this project right now, my company decided to fork a new project from here and start working on it.

Unfortunately we need to have a multiplatform project that can be published properly on Bintray, and thus we had to revisit all the code structure and publishing pipeline. This, along with the fact that we will need to audit the codebase, has made us decide to start this new project, without forgetting and mentioning your work inside it.

If you will you are super welcome to help up improve the project. From our part we will maintain the documentation and try implementing new features that are useful for us.

That being said, I'm closing this PR right now being it outdated.

@RiccardoM RiccardoM closed this Mar 19, 2019
@ligi
Copy link
Member

ligi commented Mar 19, 2019

I have time to maintain this project and review pull requests. My mentioning having no time was regarding:

Also there are some tests that are failing due to some errors. Can we look at them and try to fix them?

A bit sad this diverges now as I think this will be hard to converge again in the future.

@fullkomnun fullkomnun mentioned this pull request Jan 14, 2021
Merged
@RdeWilde
Copy link

Why exactly is this issue closed? @RiccardoM

Any other efforts for multiplatform?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@RiccardoM @ligi @RdeWilde