Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New swap tables & Swap Modal follow up #11389

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat: New swap tables & Swap Modal follow up #11389

wants to merge 21 commits into from
+601 −318

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jan 31, 2025 •
edited
Loading

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

after #11319

Needs Design check

Screenshot 📸

  • My fix has changed something on UI;

Swaps

CleanShot 2025-02-04 at 17 15 25@2x

image

Offer

CleanShot 2025-02-04 at 17 16 05@2x

@netlify Netlify
Copy link

netlify bot commented Jan 31, 2025 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 32f05bb
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/67ab5492e663ed00082c40fa
😎 Deploy Preview https://deploy-preview-11389--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian changed the title feat: New swap table and surcharge amounts visible feat: New swap tables & Swap Modal follow up Feb 3, 2025
hassnian added 12 commits February 3, 2025 18:14
@hassnian
add(trades): responsive design across trade types
eb9e6df
@hassnian
fix(GalleryItemTradesTable.vue): update surcharge prop
4970937
@hassnian
ref(trade/types.ts): make surcharge default key of BaseTrade
9a064fc
@hassnian
fix(GalleryItemTradesTable.vue): counter swaps not working from galle…
f3bf93a 
…ry item page
@hassnian
add(SurchargeTag.vue): change tag color and text based on surcharge d…
87914bd 
…irection
@hassnian
fix(NeoTag.vue): k-grey variant not working
a8140d8
@hassnian
ref(ActivityTableRowItem.vue): show trade item name while loading met…
9b83abf 
…adata
@hassnian
ref(trades): useTradeType.ts composable
83625f0
@hassnian
fix(OverviewModalDetails.vue): always show expiration
af43ab7
@hassnian
fix(TradeActivityTable.vue): swap items columns names based on tab type
7e901d8
@hassnian
add(trades) trade modal with surcharge in item :
6f0be79
@hassnian
Merge branch 'main' into issue-11385
57d2e7e
@netlify Netlify
Copy link

netlify bot commented Feb 5, 2025 •
edited
Loading

✅ Deploy Preview for polkadot ready!

Name Link
🔨 Latest commit 32f05bb
🔍 Latest deploy log https://app.netlify.com/sites/polkadot/deploys/67ab54928429590008f83887
😎 Deploy Preview https://deploy-preview-11389--polkadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian marked this pull request as ready for review February 6, 2025 03:11
@hassnian hassnian requested a review from a team as a code owner February 6, 2025 03:11
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team February 6, 2025 03:11
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vikiival
Copy link
Member

cc @Jarsen136 @preschian pls review 🙏

Jarsen136
Jarsen136 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

At least 2 approving reviews are required to merge this pull request.

Assignees

@exezbcz exezbcz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New swap table and surcharge amounts visible Swap Modal follow up
4 participants
@hassnian @vikiival @Jarsen136 @exezbcz