Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New swap table and surcharge amounts visible #11385

Open
exezbcz opened this issue Jan 29, 2025 · 2 comments · May be fixed by #11389
Open

New swap table and surcharge amounts visible #11385

exezbcz opened this issue Jan 29, 2025 · 2 comments · May be fixed by #11389
Assignees
Labels
A-atomic-swap A-profile related to profile section p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Milestone

Comments

@exezbcz
Copy link
Member

exezbcz commented Jan 29, 2025

Main

Image
Image

  • main changes are that in the swap table, it now shows the item the counterparty wants and offers. Additionally, surcharge is added

figma: https://www.figma.com/design/JXNtryaNYhY0XJNArzvPQx/Handoff?node-id=9007-36740&p=f&t=4Tjgrov1GID56iX5-11

How it works

  • we have outgoing and incoming swaps, similar, but they differ with a copy

Outgoing

you offer, you get, counterparty name, expiration, action (cancel swap or withdraw swap)

  • for the withdraw swap button, please use the correct button component with correct hover state
Image Should be this:

Image

  • expiration got icon
  • new tags (collection - for collection atomic swap, active - active offer, expired)
  • surcharge amounts
    • blue and on the correct side of grey, if you offer, its on the you offer side etc.

mobile version:

Image

Incoming

they offer, they get, counterparty name, expiration, action (accept, counter swap)

Image
same tags as with incoming

Swap tab on the gallery item

Image

  • surcharge on the offer side, if its on the "they want" side, its orange
  • if you are the creator of the swap, instead of accept and counter offer, there is cancel
  • if you are neither of the owner of the item the swap is created for nor creator of the swap, you see no actions

Color change

  • there is a slight color change on "warning"

Image

#F69E28 -> #DD840B

Color token updated in the figma, please update it across the app, the darkmode variant stays the same

and new color is purple, for our collection tag

Image

and that is about it, if you have any questions, feel free to ask

@exezbcz exezbcz added UX first Improvement for UX p2 core functionality, or is affecting 60% of app A-profile related to profile section A-atomic-swap labels Jan 29, 2025
@exezbcz exezbcz added this to the Atomic Swaps milestone Jan 29, 2025
@exezbcz
Copy link
Member Author

exezbcz commented Jan 29, 2025

cc @Jarsen136 or @hassnian

@hassnian hassnian self-assigned this Jan 29, 2025
@exezbcz
Copy link
Member Author

exezbcz commented Jan 30, 2025

update for collection tag

Image

either its on the offer or they want side

@hassnian hassnian linked a pull request Jan 31, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-atomic-swap A-profile related to profile section p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants