Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double deploy on netlify for all the branchs #11326

Open
Jarsen136 opened this issue Jan 1, 2025 · 10 comments · May be fixed by #11407
Open

Double deploy on netlify for all the branchs #11326

Jarsen136 opened this issue Jan 1, 2025 · 10 comments · May be fixed by #11407

Comments

@Jarsen136
Copy link
Contributor

Jarsen136 commented Jan 1, 2025

It's related to the deploy environment

new one: https://deploy-preview-11317--polkadot.netlify.app/ahp/collection/244

original: https://deploy-preview-11317--koda-canary.netlify.app/ahp/collection/244

Originally posted by @Jarsen136 in #11318 (comment)

image image

It looks like every PR has these double deployment. We should only keep one netlify deployment env.

@vikiival Do you have access to the netlify dashboard?

@vikiival
Copy link
Member

vikiival commented Jan 1, 2025

Hey @Jarsen136,
Unfortunatelly I do not have access to koda-canary netlify
and because we had an issue with deploy previews I have made the "polkadot" one for the sake of testing.

Cc @kodadot/internal-dev

@Jarsen136
Copy link
Contributor Author

Hey @Jarsen136, Unfortunatelly I do not have access to koda-canary netlify and because we had an issue with deploy previews I have made the "polkadot" one for the sake of testing.

Cc @kodadot/internal-dev

Got it. In this case, we need to update the CORS domain white list accordingly. (worker \ font-awesome-icon etc.)

@vikiival
Copy link
Member

vikiival commented Jan 2, 2025

Seems like the original issue (error decoding lambda response: error decoding lambda response: unexpected end of JSON input) has been resolved

Screenshot 2025-01-02 at 12 08 18

Since new deploy works, I am closing my deploy

Screenshot 2025-01-02 at 12 08 50

@Jarsen136
Copy link
Contributor Author

We may still need to set up the preview environment on polkadot.netlify.app

@preschian
Copy link
Member

Anyway, now all our Netlify deployments are failing. For this case, I'm still not sure what the root cause is. I've already tried to disable the functions on Netlify but it didn't help.

The last error log I got is something like this:

ERROR Uncaught Exception {"errorType":"Runtime.ImportModuleError","errorMessage":"Error: Cannot find module '@vue/compiler-dom'\nRequire stack:\n- /var/task/.netlify/functions-internal/server/server.mjs","stack":["Runtime.ImportModuleError: Error: Cannot find module '@vue/compiler-dom'","Require stack:","- /var/task/.netlify/functions-internal/server/server.mjs"," at _loadUserApp (file:///var/runtime/index.mjs:1087:17)"," at async UserFunction.js.module.exports.load (file:///var/runtime/index.mjs:1119:21)"," at async start (file:///var/runtime/index.mjs:1282:23)"," at async file:///var/runtime/index.mjs:1288:1"]}

Maybe anyone has some ideas about this?

@vikiival
Copy link
Member

Could be related to

@roiLeo
Copy link
Contributor

roiLeo commented Feb 13, 2025

Anyway, now all our Netlify deployments are failing. For this case, I'm still not sure what the root cause is. I've already tried to disable the functions on Netlify but it didn't help.

The last error log I got is something like this:

ERROR Uncaught Exception {"errorType":"Runtime.ImportModuleError","errorMessage":"Error: Cannot find module '@vue/compiler-dom'\nRequire stack:\n- /var/task/.netlify/functions-internal/server/server.mjs","stack":["Runtime.ImportModuleError: Error: Cannot find module '@vue/compiler-dom'","Require stack:","- /var/task/.netlify/functions-internal/server/server.mjs"," at _loadUserApp (file:///var/runtime/index.mjs:1087:17)"," at async UserFunction.js.module.exports.load (file:///var/runtime/index.mjs:1119:21)"," at async start (file:///var/runtime/index.mjs:1282:23)"," at async file:///var/runtime/index.mjs:1288:1"]}

had this issue on nft-shop project and it was a missing peer dependencie (vue & vue-router)

@vikiival
Copy link
Member

had this issue on nft-shop project and it was a missing peer dependencie (vue & vue-router)

No idea why but it works
89b1092

@vikiival vikiival linked a pull request Feb 13, 2025 that will close this issue
@roiLeo
Copy link
Contributor

roiLeo commented Feb 13, 2025

No idea why but it works 89b1092

I can't find the original issue where I found the answer but iirc, it was a netlify problem, they made a nuxt patch that's not out yet. Glad to help 🫡

@preschian
Copy link
Member

Woah, thank you @roiLeo 🚀

Finally! This probably means we can upgrade our Nuxt version. In the past, when I tried to upgrade the Nuxt version, I got this error as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants