Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap Modal follow up #11212

Open
hassnian opened this issue Dec 5, 2024 · 2 comments · May be fixed by #11389
Open

Swap Modal follow up #11212

hassnian opened this issue Dec 5, 2024 · 2 comments · May be fixed by #11389
Assignees
@hassnian
Labels
A-atomic-swap p2 core functionality, or is affecting 60% of app UX first Improvement for UX

Comments

@hassnian
Copy link
Contributor

hassnian commented Dec 5, 2024

we need to show the surcharge direction based on the user opening the modal , either the user is also

  • requesting x amount
  • sending x amount

also

in the swap modal i would only add: your send, you get
so its more clear which nft is actually yours

Originally posted by @exezbcz in #11182 (comment)
@hassnian hassnian mentioned this issue Dec 5, 2024
Open
@exezbcz
Copy link
Member

exezbcz commented Jan 29, 2025

on it

@exezbcz
Copy link
Member

exezbcz commented Jan 29, 2025

added to figma:

Image
https://www.figma.com/design/JXNtryaNYhY0XJNArzvPQx/Handoff?node-id=9007-36740&p=f&t=4Tjgrov1GID56iX5-11

@exezbcz exezbcz added p2 core functionality, or is affecting 60% of app and removed design-request labels Jan 29, 2025
@hassnian hassnian self-assigned this Feb 3, 2025
@hassnian hassnian linked a pull request Feb 3, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hassnian hassnian

Labels
A-atomic-swap p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: New swap tables & Swap Modal follow up hassnian/nft-gallery
2 participants
@hassnian @exezbcz