Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chainguard annotations are, but should not be, propagated to multi-platform manifest #1231

Open
MikeSpreitzer opened this issue Feb 6, 2024 · 3 comments
Labels
lifecycle/stale question Further information is requested

Comments

@MikeSpreitzer
Copy link

When I ko build a multi-platform manifest, my manifest ends up with annotations attributing it to chainguard. Here is what I found:

{"org.opencontainers.image.authors": "Chainguard Team https://www.chainguard.dev/",
 "org.opencontainers.image.base.digest": "sha256:fce1fdce595332afe7f339303ae288c349c4e4139d926f8c7ccf4b7ca2911553",
 "org.opencontainers.image.base.name": "cgr.dev/chainguard/static:latest",
 "org.opencontainers.image.source": "https://github.com/chainguard-images/images/tree/main/images/static",
 "org.opencontainers.image.url": "https://edu.chainguard.dev/chainguard/chainguard-images/reference/static/"}
@cpanato
Copy link
Member

cpanato commented Feb 6, 2024

if you don't specify the base image that you want to use in your ko build it will use a default one which is cgr.dev/chainguard/static:latest you can check where we define that in https://github.com/ko-build/ko/blob/main/pkg/commands/options/build.go#L33

@cpanato cpanato added the question Further information is requested label Feb 6, 2024
@MikeSpreitzer
Copy link
Author

This is not a question. This is a bug. The problem is not the annotations that identify the base image. The problem is the other annotations.

Copy link

github-actions bot commented May 8, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants