Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: specify KO_DOCKER_REPO in .ko.yaml #1228

Open
miguelvr opened this issue Feb 5, 2024 · 2 comments
Open

feat: specify KO_DOCKER_REPO in .ko.yaml #1228

miguelvr opened this issue Feb 5, 2024 · 2 comments

Comments

@miguelvr
Copy link

miguelvr commented Feb 5, 2024

Description

In order to facilitate local reproducible builds for developers, it would be a nicer UX if we could specify a default image repo, globally or per image, in .ko.yaml. This can be useful in scenarios like monorepos and generally reduces the surface for user error.

Proposal

For images with different repos:

imageRepo: ghcr.io/org/repo1

- id: foo
  dir: ./foo
  main: . 
- id: bar
  dir: ./bar
  main: . 
  imageRepo: ghcr.io/org/repo2

foo → pushed to ghcr.io/org/repo/foo
bar → pushed to ghcr.io/org/repo2/bar

Note

To keep backward compatibility, KO_DOCKER_REPO would overwrite any of these options.

Copy link

github-actions bot commented May 6, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@n0nvme
Copy link

n0nvme commented May 8, 2024

Will be extremely useful for building with --bare flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants