Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise warning to users on empty compile commands #179

Closed
kkharji opened this issue Apr 19, 2023 · 1 comment · Fixed by #184
Closed

Raise warning to users on empty compile commands #179

kkharji opened this issue Apr 19, 2023 · 1 comment · Fixed by #184
Labels
daemon nvim Neovim client vscode VSCode client

Comments

@kkharji
Copy link
Owner

kkharji commented Apr 19, 2023 •
edited
Loading

When opening a project for the first time, xbase is expected to build and compile the project to generate compile commands to support LSP features, then communicate to the user the build and compile result. However, it does not make it obvious to the user that the project failed to build and compile, and acts as if it was successfully built and ready for development

Raise warning to user on empty compile commands. Later, similar to #178. It will help debugging effort.
This was referenced Apr 20, 2023
Merged
Merged
kkharji added a commit to xbase-lab/xclog that referenced this issue Apr 21, 2023
@kkharji
feat: support SwiftDriver (#3)
4705618 
Adds support for SwiftDriver compile commands. Note, This PR also remove escape chars from file-path of file list to fix error reading the file content. 

See: kkharji/xbase#178, kkharji/xbase#179
kkharji added a commit to xbase-lab/xclog that referenced this issue Apr 21, 2023
@kkharji
fix: treating swift-frontend as error (#4)
a94cbe5 
See: kkharji/xbase#178, kkharji/xbase#179
@kkharji
Copy link
Owner Author

kkharji commented Apr 21, 2023 •
edited
Loading

It turned out that the project was compiled successfully, but no compile commands was generated. This was fixed in xbase-lab/xclog@4705618. in term of socket responses, is still an issue, even though the error above might not be reproduced thanks to xbase-lab/xclog@a94cbe5. However, try/catch for decoding should be implemented, just in case. This shell be handled in #180. Therefore, changing the purpose of this issue to raise warning to users on empty compile commands.

@kkharji kkharji changed the title Project build failure isn't handled correctly by xbase Raise warning to users on empty compile commands Apr 21, 2023
@kkharji kkharji added nvim Neovim client daemon vscode VSCode client labels Apr 22, 2023
@kkharji kkharji mentioned this issue Apr 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
daemon nvim Neovim client vscode VSCode client
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref: raise warning on empty compile commands kkharji/xbase
1 participant
@kkharji