Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language filter to library screen #4188

Open
wildasin opened this issue Jan 23, 2025 · 3 comments
Open

Add language filter to library screen #4188

wildasin opened this issue Jan 23, 2025 · 3 comments
Assignees
Milestone

Comments

@wildasin
Copy link

Is your feature request related to a problem? Please describe.
The TED talks ZIM files seem to have bad metadata that associates them with every possible language. My other content is correctly labeled as only English. So, to get to any of my other content, I have to scroll down dozens of times through "Azerbaijani" TED talks, "Arabic" TED talks, etc., in alphabetical order till I reach English.

Describe the solution you'd like
This could be worked around with a language filter on the library screen so that I could limit it to English. The preference should be saved somewhere so it is sticky across usage sessions.

Describe alternatives you've considered
Obviously the maintainer of those ZIMs should fix the metadata. However, this would make the UI more robust against bad metadata and might be more broadly useful to people as well, for example users with a legitimately multilingual library.

@MohitMaliFtechiz
Copy link
Collaborator

@wildasin This feature was implemented due to #3892 in #3915, that's why you are seeing like this. However, your proposal is good for UX. @kelson42 What do you think about @wildasin's proposal?

@wildasin
Copy link
Author

wildasin commented Jan 24, 2025

@wildasin This feature was implemented due to #3892 in #3915, that's why you are seeing like this.

Thanks, good context.

BTW, a tactical short-term alternative solution that should require virtually no effort would be simply to display the user's preferred language (as selected in Settings) at the top of the library screen rather than its alphabetical position. I still think the filter is better, but I mention this just in case a new UI feature can't be in scope right now for whatever reason.

@salehdemir
Copy link

Can you please assign me this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants