libmkv source code bugs

[GoogleCodeExporter]

In libmkv the following bugs have been found:

1) Function "Ebml_Serialize" has 4 arguments in the declaration (in 
EbmlWriter.h), but 3 arguments in the definition (in EbmlBufferWriter.c). The 
function calls are all with 4 arguments. Imho the last argument will be ignored.

2) Function Ebml_WriteLen (in EbmlWriter.c) contains 2 bugs:

2.1) Variabele "size" is initialized with value 8. Immediately after the 
initialization it is used in a "for" routine, starting with "1".

2.2) The last argument of function call "Ebml_Serialize" is also the variabele 
"size". However, function "ebml_Serialize" has only 3 arguments (see bug 1).

Original issue reported on code.google.com by [email protected] on 24 Aug 2011 at 11:10

[GoogleCodeExporter]

Original comment by [email protected] on 24 Aug 2011 at 11:10

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Rethinking  bug "2.1", I think that variable "size" was accidentaly used in the 
"for" routine. It makes no sense. 

And when calling function "Ebml_Serialize", the initial value of "size" (which 
is 8) is equal to the value of "sizeof(val)". 

So I think that the variabele "size" can be eliminated alltogether, when for 
the "for" routine the variabele "i" will be used.

Original comment by [email protected] on 24 Aug 2011 at 11:34

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Checkins are welcome. :-) 

Original comment by [email protected] on 16 Feb 2012 at 9:08

• Changed state: Available
• Added labels: Type-Enhancement
• Removed labels: ****