Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete Data of Countries/Divisions #49

Open
afrasiyabhaider opened this issue Apr 2, 2021 · 7 comments
Open

Incomplete Data of Countries/Divisions #49

afrasiyabhaider opened this issue Apr 2, 2021 · 7 comments

Comments

@afrasiyabhaider
Copy link

afrasiyabhaider commented Apr 2, 2021

I was using this package, But it doesn't have a complete record of all countries e.g Pakistan doesn't have any divisions
Please complete the db if you need any assistance from me I'll be happy to assist you :)

@khsing

@ilyaskazi
Copy link

@afrasiyabhaider I stumble upon this package and installed. Same issue with db for country of India. No division found and incomplete list of cities.

@khsing This is a very good package but unfortunately having an incomplete db. Can you seed any good geo db which would be a good start for us when we install your package. This would motivate and keep going.

@seche
Copy link

seche commented Oct 12, 2021

I updated the seeds to have all countries, divisions and cities with 5000+ population in my pull request
#51

@Dach0
Copy link

Dach0 commented Nov 9, 2021

I still cannot see some of the towns from GeoNames listed in cities5000.zip. (i.e. Split or (Šibenik)Sibenik from Coratia). And also, in WorldCitiesTableSeeder divisions are listed instead of cities for Croatia. I see some >5000 population cities are missing for countries like Serbia or Montenegro.

@seche
Copy link

seche commented Nov 12, 2021

I still cannot see some of the towns from GeoNames listed in cities5000.zip. (i.e. Split or (Šibenik)Sibenik from Coratia). And also, in WorldCitiesTableSeeder divisions are listed instead of cities for Croatia. I see some >5000 population cities are missing for countries like Serbia or Montenegro.

Good eye, I checked and it looks like divisions were added as cities for Croatia. I know I was having issues with cities because the tables are big. Let me see if I can re-run the cities portion. There should be 195 cities for Croatia as per my records. Will also check Serbia or Montenegro. Keep an eye on my next push ;)

@Dach0
Copy link

Dach0 commented Nov 14, 2021

OK, bear in mind that Serbia and Montenegro are separated countries from 2006 :) Maybe I could contribute to a package for Balkan countries if I catch some time in the near future. Anyway, I'll be watching this repo. Best regards.

@seche
Copy link

seche commented Dec 15, 2021

@Dach0 It took longer than expected and I probably spent way too much time on this but the data now includes all cities (200k~)

Its a lot of work migrating the data and would be easier to potentially convert the data model to match geonames but for now this should give us 99% there.

@Dach0
Copy link

Dach0 commented Dec 16, 2021

@Dach0 It took longer than expected and I probably spent way too much time on this but the data now includes all cities (200k~)

Its a lot of work migrating the data and would be easier to potentially convert the data model to match geonames but for now this should give us 99% there.

That's great news. I'll update the package and of course, recommend it to others :) Cheers, keep up the good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants