-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add a basic support for PowerPC builds (or just generic CPU) #5
Comments
Perhaps GCC builtin can be used, like here: https://github.com/nmslib/nmslib/blob/ade4bcdc9dd3719990de2503871450b8a62df4a5/similarity_search/include/portable_prefetch.h#L17-L27 |
Thanks for the GitHub issue. You're referring to the 32-bit PowerPC? Hmmm, I guess I didn't know people still used this. I'm genuinely interested/curious to hear what you're doing with this architecture. In terms of fixing this, I don't have access to this architecture. You're probably right that conditionals to detect the presence of x86 would work. I think there are two ways forward:
Sound reasonable? I think the ball is in your court. Best, Evan |
@evanbiederstedt Thank you for responding! I checked Let me see if I can fix it. Won’t invest much time if it happens to be non-trivial, but why not try at least. P. S. It looks like your code is improved over the original, right? And what you define for Lines 50 to 53 in aaf8ac4
GCC builtins do work there. There is a way to use assembler too, but perhaps unneeded, since GCC does that via builtin anyway. Ref: https://github.com/ivmai/bdwgc/blob/58e55d40a1a0220c511feaea9217cffe38dcdccb/include/private/gcconfig.h#L1201-L1207
I got a PowerMac two year ago and thought I can run some Bayesian models with Stan on it. Turned out that |
The first issue when building on PowerPC that a wrong intrinsics header gets pulled in:
Those implementations are little-endian and require VSX support in ISA, which is a small subset of PowerPC cpus.
When that header is removed, build fails a step further due to a missing define for prefetch:
Perhaps adding proper intrinsics for PowerPC is not easy, but maybe generic CPU fallback can be added (just considering endianness)?
The text was updated successfully, but these errors were encountered: