Merge pull request #842 from kernelkit/update-vlan-separation-test

test: bridge_vlan_separation: Make test more robust

Author: mattiaswal

test/case/ietf_interfaces/bridge_vlan_separation/Readme.adoc

@@ -40,6 +40,9 @@ endif::topdoc[]
 . Verify ping 10.0.0.4 from host:data11
 . Verify ping not possible host:data10->10.0.0.4, host:data11->10.0.0.3, host:data10->10.0.0.2, host:data11->10.0.0.1
 . Verify MAC broadcast isolation within VLANs
+. Send ping to 10.0.0.255 from host:data10
+. Verify broadcast is received on host:data20
+. Verify broadcast is NOT received on host:data11 and host:data21
 
 
 <<<

test/case/ietf_interfaces/bridge_vlan_separation/test.py

@@ -24,6 +24,7 @@
 ....
 """
 import infamy
+import subprocess
 
 with infamy.Test() as test:
     with test.step("Set up topology and attach to target DUT"):
@@ -168,21 +169,25 @@
                             lambda: ns11.must_not_reach("10.0.0.3"),
                             lambda: ns10.must_not_reach("10.0.0.2"),
                             lambda: ns11.must_not_reach("10.0.0.1"))
-            
+
         with test.step("Verify MAC broadcast isolation within VLANs"):
             # Clear ARP entries/queued packets
             ns10.runsh("ip neigh flush all")
             ns11.runsh("ip neigh flush all")
             ns20.runsh("ip neigh flush all")
             ns21.runsh("ip neigh flush all")
 
-            lambda: ns10.runsh("ping -b -c 5 -i 0.5 10.0.0.255"),
-            
-            lambda: ns20.must_receive("broadcast or arp"),
-            
-            infamy.parallel(
-                lambda: ns11.must_not_receive("broadcast or arp"),
-                lambda: ns21.must_not_receive("broadcast or arp")
-            )
+            # Sending IP subnet broadcast, resulting in MAC broadcast
+            with test.step("Send ping to 10.0.0.255 from host:data10"):
+                process=ns10.popen("ping -b -c 5 -i 0.5 10.0.0.255".split(), stderr=subprocess.DEVNULL, stdout=subprocess.DEVNULL)
+
+            with test.step("Verify broadcast is received on host:data20"):
+                ns20.must_receive("ip dst 10.0.0.255")
+
+                with test.step("Verify broadcast is NOT received on host:data11 and host:data21"):
+                    infamy.parallel(
+                        lambda: ns11.must_not_receive("ip dst 10.0.0.255"),
+                        lambda: ns21.must_not_receive("ip dst 10.0.0.255")
+                    )
 
     test.succeed()