Skip to content

Commit

Permalink
Disable bridge multicast snooping (IGMP/MLD) by default
Browse files Browse the repository at this point in the history
The Marvell mv88e6xxx switch driver currently used in active projects do
not support multicast router ports properly yet.  Considering that Infix
do not yet have YANG support for configuring IGMP/MLD snooping, we have
decided to disable it in bridge setups by default.

Signed-off-by: Joachim Wiberg <[email protected]>
  • Loading branch information
troglobit committed Oct 13, 2023
1 parent 830c885 commit 1698c66
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/confd/src/ietf-interfaces.c
Original file line number Diff line number Diff line change
Expand Up @@ -812,15 +812,17 @@ static int netdag_gen_bridge(struct dagger *net, struct lyd_node *dif,
const char *op = add ? "add" : "set";
struct lyd_node *vlans, *vlan;
int vlan_filtering, pvid, fwd_mask;
int mcast_snooping;
const char *proto;
FILE *br = NULL;
int err = 0;

vlan_filtering = bridge_vlan_settings(cif, &proto, &pvid);
mcast_snooping = 0; /* Not supported yet */
fwd_mask = bridge_fwd_mask(cif);

fprintf(ip, "link %s dev %s type bridge group_fwd_mask %d vlan_filtering %d",
op, brname, fwd_mask, vlan_filtering ? 1 : 0);
fprintf(ip, "link %s dev %s type bridge group_fwd_mask %d vlan_filtering %d mcast_snooping %d",
op, brname, fwd_mask, vlan_filtering ? 1 : 0, mcast_snooping ? 1 : 0);
if (!vlan_filtering) {
fputc('\n', ip);
goto done;
Expand Down

0 comments on commit 1698c66

Please sign in to comment.