api.main: fix delete user group endpoint #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenySadadia
force-pushed
the
fix-delete-user-group
branch
from
e0d9c2b
to
50ec22d
Compare
|
Addressed |
Fix `DELETE /group/{group-id}` endpoint's
response model by using `pagination_ctx`.
Also return `HTTP 204` status code for successful
delete operation as per the convention.
Signed-off-by: Jeny Sadadia <[email protected]>
JenySadadia
force-pushed
the
fix-delete-user-group
branch
from
50ec22d
to
ce14278
Compare
|
seems working at staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
Fix
DELETE /group/{group-id}endpoint's response model by usingpagination_ctx.