Fix overflow #244
Open
Fix overflow #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nope, definitely this has some issues. Can you figure out the correct fix? Edit: I had a hard time figuring out if keycodes are 0-indexed or 1-indexed in the code |
|
Best guess is that this works now. I think it was only an issue on keyboards with 128+ keys? Certainly I can't reproduce it on all machines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes issue #239, where args.flags was getting clobbered by an overflow
The problem was that sizeof(char_or_func) is 129, not 128, due to the trailing null byte.
However, I've tested logkeys on two computers, and on both I have unrelated keymap issues. Could someone please make sure this isn't breaking anything horribly before merging it? (ex. that I'm not chopping off a key?)
Fixes #239.