Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL extraction when the regex falls short #1190

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix URL extraction when the regex falls short #1190

wants to merge 8 commits into from

Conversation

lfoppiano
Copy link
Collaborator

This PR fixes the URL extraction when the regular expression is shorter than the actual target (the annotated URL).

@lfoppiano lfoppiano mentioned this pull request Oct 24, 2024
Open
@lfoppiano lfoppiano marked this pull request as draft October 24, 2024 11:56
@coveralls
Copy link

coveralls commented Oct 24, 2024 •
edited
Loading

Coverage Status

coverage: 40.768% (+0.01%) from 40.755%
when pulling e478c4f on fix-url-extraction-regex-shorter
into be44579 on master.

@lfoppiano lfoppiano marked this pull request as ready for review October 26, 2024 04:54
@lfoppiano lfoppiano linked an issue Oct 31, 2024 that may be closed by this pull request
some URLs are not extracted in DAS #1184
Closed
@lfoppiano lfoppiano removed a link to an issue Oct 31, 2024
some URLs are not extracted in DAS #1184
Closed
@lfoppiano lfoppiano linked an issue Nov 8, 2024 that may be closed by this pull request
URLs where the regex capture less than the annotations are not consolidated with the clickable links from the PDF document #1191
Open
@lfoppiano
Copy link
Collaborator Author

Added a fix for the case as such:

image

Where genius editors are adding the - for breaking up an URL over two lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kermitt2 kermitt2 Awaiting requested review from kermitt2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lfoppiano @coveralls @Bubblbu