Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: race condition in keploy record #1851

Closed
1 task done
shivamsouravjha opened this issue Apr 26, 2024 · 2 comments · Fixed by #1914
Closed
1 task done

[bug]: race condition in keploy record #1851

shivamsouravjha opened this issue Apr 26, 2024 · 2 comments · Fixed by #1914
Labels
bug Something isn't working Go Pull requests that update Go code Good First Issue Good for newcomers keploy

Comments

@shivamsouravjha
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

  • testCount is concurrently written and read in case of keploy record.

Steps to reproduce

  • Build the binary with go build -race -tags=viper_bind_struct -o keploybin . && sudo mv keploybin /usr/local/bin/keploybin
  • Try running express-mongoose in record.
  • While closing race condition occurs

Environment

None

Version

Cloud

Repository

keploy
@shivamsouravjha shivamsouravjha added bug Something isn't working Good First Issue Good for newcomers Go Pull requests that update Go code labels Apr 26, 2024
@dxtym
Copy link
Contributor

dxtym commented May 5, 2024

Hi! May I give this a try?

@shivamsouravjha
Copy link
Contributor Author

sure @dxtym you can work on the issue!

@dxtym dxtym mentioned this issue May 7, 2024
Closed
12 tasks
@dxtym dxtym mentioned this issue May 31, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Go Pull requests that update Go code Good First Issue Good for newcomers keploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/race cond dxtym/keploy
fix: race condition in keploy record dxtym/keploy
2 participants
@shivamsouravjha @dxtym