-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't syntax highlight diffs #9
Comments
I think the syntax highlighting is good, but just not well implemented. It mixes the keyword highlighting with the diff highlighting: I think it would be better if not-changed lines had syntax highlighting, but +/- lines were all green and red, respectively. Or the syntax highlighting could always be there, but the +/- lines have green/red background color. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The extra color is more confusing. Syntax highlighting is great for writing code, where the focus is on keywords. However, for diffs the focus should be on what changed. Syntax highlighting for diffs confuses that.
Reference: https://twitter.com/keplersj/status/933591387903164416
The text was updated successfully, but these errors were encountered: