-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use babel traverse #156
use babel traverse #156
Conversation
src/index.js
Outdated
@@ -228,9 +229,10 @@ function applyMacros({ | |||
* | |||
* See: https://github.com/kentcdodds/import-all.macro/issues/7 | |||
*/ | |||
state.file.scope.path.traverse({ | |||
console.log(state.file.ast); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this console log
console.log(state.file.ast); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should've been formatted as well (no semicolons).
@kentcdodds sorry the pre-commit script seems to crash on windows 😅 |
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 97 98 +1
Branches 22 22
=========================================
+ Hits 97 98 +1
Continue to review full report at Codecov.
|
Oh no! Sorry about that! If you could figure out why that would be a great help 😅 Thanks for this change! |
Is this PR still a draft or is it ready to be merged? |
It seems good, I'll take a look what the issue is |
@all-contributors please add @JoviDeCroock for code and tests |
I've put up a pull request to add @JoviDeCroock! 🎉 |
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves: #121
This uses
@babel/traverse
rather than the stateful one